lkml.org 
[lkml]   [2021]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drivers: firmware: fix kconfig dependency on CRYPTO
Date
commit 72304490d9df7d6af2e6851cc5762908abd52889
Author: Julian Braha <julianbraha@gmail.com>
Date: Fri Feb 19 18:36:22 2021 -0500

drivers: firmware: fix kconfig dependency on CRYPTO

When EFI_EMBEDDED_FIRMWARE is enabled and CRYPTO is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]

This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256,
without depending on or selecting CRYPTO, despite that config option
being subordinate to CRYPTO.

Signed-off-by: Julian Braha <julianbraha@gmail.com>

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@ endmenu
config EFI_EMBEDDED_FIRMWARE
bool
depends on EFI
+ select CRYPTO
select CRYPTO_LIB_SHA256

config UEFI_CPER

\
 
 \ /
  Last update: 2021-02-20 00:47    [W:0.034 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site