lkml.org 
[lkml]   [2021]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/2] Fixes for the tty ledtrigger
Date
Hello,

this drops the unused label that the kernel test robot found. Thanks for
catching that.

I also added Pavel's Ack.

Best regards
Uwe

Uwe Kleine-König (2):
leds: trigger: Fix error path to not unlock the unlocked mutex
leds: trigger/tty: Use led_set_brightness_sync() from workqueue

drivers/leds/trigger/ledtrig-tty.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

Range-diff against v1:
1: 7fc10ce8eb8b ! 1: ed39ad41cd91 leds: trigger: Fix error path to not unlock the unlocked mutex
@@ Commit message

Reported-by: Pavel Machek <pavel@ucw.cz>
Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
+ Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

## drivers/leds/trigger/ledtrig-tty.c ##
@@ drivers/leds/trigger/ledtrig-tty.c: static ssize_t ttyname_store(struct device *
} else {
ttyname = NULL;
}
+@@ drivers/leds/trigger/ledtrig-tty.c: static ssize_t ttyname_store(struct device *dev,
+
+ trigger_data->ttyname = ttyname;
+
+-out_unlock:
+ mutex_unlock(&trigger_data->mutex);
+
+ if (ttyname && !running)
2: fe3d28f4a786 ! 2: a812318f4cfc leds: trigger/tty: Use led_set_brightness_sync() from workqueue
@@ Commit message

Reported-by: Pavel Machek <pavel@ucw.cz>
Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
+ Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

## drivers/leds/trigger/ledtrig-tty.c ##
--
2.29.2

\
 
 \ /
  Last update: 2021-02-19 14:35    [W:0.052 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site