Messages in this thread | | | Date | Thu, 18 Feb 2021 12:21:55 +0000 | From | Chris Down <> | Subject | Re: [PATCH v4] printk: Userspace format enumeration support |
| |
Thanks for all your feedback, Petr and Steven. :-)
Petr, I believe this is a comprehensive checklist of everything we discussed for v5 -- any chance you could double check I'm not missing anything you folks wanted? Thanks!
- Use seq_file iterator again instead of simple_open + size - Remove debugfs file first to avoid ENOENT - Tear down datastructures if debugfs fails - Human readable output format - Display file/line - Rename to CONFIG_PRINTK_INDEX, or... something - Move to another file, kernel/printk/debug_formats.c or similar - Use `struct module *mod` instead of calling it module - Add documentation for printk_fmt_sec (or whatever it will be called) - Rename things to pf_, pi_, or something - See if it's safe to pass a printk_fmt_sec to seq_file instead of a module - Handle cont + level - Don't expose level/KERN_SOH directly
| |