Messages in this thread | | | Date | Tue, 16 Feb 2021 16:00:32 -0500 | From | Johannes Weiner <> | Subject | Re: code style: Re: [PATCH v4] printk: Userspace format enumeration support |
| |
On Tue, Feb 16, 2021 at 05:27:08PM +0000, Chris Down wrote: > Petr Mladek writes: > > I wonder if we could find a better name for the configure switch. > > I have troubles to imagine what printk enumeration might mean. > > Well, it might be because I am not a native speaker. > > > > Anyway, the word "enumeration" is used only in the configure option. > > Everything else is "printk_fmt" > > > > What about DEBUG_PRINTK_FORMATS? > > Hmm, I don't like DEBUG_PRINTK_FMTS because it's not about debugging, it's > about enumeration, I guess :-) > > The name should reflect that this catalogues the available printks in the > kernel -- "debugging" seems to imply something different. > > I'm ok with a different name like "printk catalogue" or something like that > if you prefer. Personally I think "printk enumeration" is fairly clear -- > it's about enumerating the available printks -- but anything that captures > that spirit is fine.
How about config PRINTK_INDEX?
| |