Messages in this thread | | | Subject | Re: [PATCH v1 10/18] media: hantro: Add helper functions for buffer information | From | Ezequiel Garcia <> | Date | Wed, 17 Feb 2021 17:31:30 -0300 |
| |
Hi Benjamin,
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Add help functions to retrieve buffer address and size. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> > --- > drivers/staging/media/hantro/hantro.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/staging/media/hantro/hantro.h b/drivers/staging/media/hantro/hantro.h > index 2523c0d010df..a9b80b2c9124 100644 > --- a/drivers/staging/media/hantro/hantro.h > +++ b/drivers/staging/media/hantro/hantro.h > @@ -430,6 +430,22 @@ hantro_get_dec_buf_addr(struct hantro_ctx *ctx, struct vb2_buffer *vb) > return vb2_dma_contig_plane_dma_addr(vb, 0); > } > > +static inline size_t > +hantro_get_dec_buf_size(struct hantro_ctx *ctx, struct vb2_buffer *vb) > +{ > + if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > + return ctx->postproc.dec_q[vb->index].size; > + return vb2_plane_size(vb, 0); > +} > + > +static inline void * > +hantro_get_dec_buf(struct hantro_ctx *ctx, struct vb2_buffer *vb) > +{ > + if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > + return ctx->postproc.dec_q[vb->index].cpu; > + return vb2_plane_vaddr(vb, 0); > +} > +
It may sound like a nitpick but I think you could just squash this change where it's needed. That way it's easier to review and see why this was added.
Thanks, Ezequiel
| |