Messages in this thread | | | Date | Fri, 12 Feb 2021 07:31:40 -0800 | From | Richard Cochran <> | Subject | Re: [PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock. |
| |
On Thu, Feb 11, 2021 at 11:38:44PM -0500, vincent.cheng.xh@renesas.com wrote:
> +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) > +{ > + char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL state %d";
Probably you want: const char *fmt
> diff --git a/drivers/ptp/ptp_clockmatrix.h b/drivers/ptp/ptp_clockmatrix.h > index 645de2c..fb32327 100644 > --- a/drivers/ptp/ptp_clockmatrix.h > +++ b/drivers/ptp/ptp_clockmatrix.h > @@ -15,7 +15,6 @@ > #define FW_FILENAME "idtcm.bin" > #define MAX_TOD (4) > #define MAX_PLL (8) > -#define MAX_OUTPUT (12)
...
> @@ -123,7 +137,6 @@ struct idtcm_channel { > enum pll_mode pll_mode; > u8 pll; > u16 output_mask; > - u8 output_phase_adj[MAX_OUTPUT][4]; > };
Looks like this removal is unrelated to the patch subject, and so it deserves its own small patch.
Acked-by: Richard Cochran <richardcochran@gmail.com>
| |