lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] samples/bpf: fix swap.cocci warning
Date
Fix following swap.cocci warning:
./samples/bpf/xsk_fwd.c:660:22-23:
WARNING opportunity for swap()

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
samples/bpf/xsk_fwd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/samples/bpf/xsk_fwd.c b/samples/bpf/xsk_fwd.c
index 1cd97c84c337..e82582b225d3 100644
--- a/samples/bpf/xsk_fwd.c
+++ b/samples/bpf/xsk_fwd.c
@@ -653,9 +653,7 @@ static void swap_mac_addresses(void *data)
struct ether_addr *dst_addr = (struct ether_addr *)&eth->ether_dhost;
struct ether_addr tmp;

- tmp = *src_addr;
- *src_addr = *dst_addr;
- *dst_addr = tmp;
+ swap(*src_addr, *dst_addr);
}

static void *
--
2.17.1
\
 
 \ /
  Last update: 2021-12-08 12:34    [W:0.040 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site