lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subject[PATCH 00/22] Refactor perf cpumap
From
Perf cpu map has various functions where a cpumap and index are passed
in order to load the cpu. A problem with this is that the wrong index
may be passed for the cpumap, causing problems like aggregation on the
wrong CPU:
https://lore.kernel.org/lkml/20211204023409.969668-1-irogers@google.com/

This patch set refactors the cpu map API, greatly reducing it and
explicitly passing the cpu (rather than the pair) to functions that
need it. Comments are added at the same time.

Ian Rogers (22):
libperf: Add comments to perf_cpu_map.
perf stat: Add aggr creators that are passed a cpu.
perf stat: Switch aggregation to use for_each loop
perf stat: Switch to cpu version of cpu_map__get
perf cpumap: Switch cpu_map__build_map to cpu function
perf cpumap: Remove map+index get_socket
perf cpumap: Remove map+index get_die
perf cpumap: Remove map+index get_core
perf cpumap: Remove map+index get_node
perf cpumap: Add comments to aggr_cpu_id
perf cpumap: Remove unused cpu_map__socket
perf cpumap: Simplify equal function name.
perf cpumap: Rename empty functions.
perf cpumap: Document cpu__get_node and remove redundant function
perf cpumap: Remove map from function names that don't use a map.
perf cpumap: Remove cpu_map__cpu, use libperf function.
perf cpumap: Refactor cpu_map__build_map
perf cpumap: Rename cpu_map__get_X_aggr_by_cpu functions
perf cpumap: Move 'has' function to libperf
perf cpumap: Add some comments to cpu_aggr_map
perf cpumap: Trim the cpu_aggr_map
perf stat: Fix memory leak in check_per_pkg

tools/lib/perf/cpumap.c | 7 +-
tools/lib/perf/include/internal/cpumap.h | 9 +-
tools/lib/perf/include/perf/cpumap.h | 1 +
tools/perf/arch/arm/util/cs-etm.c | 16 +-
tools/perf/builtin-ftrace.c | 2 +-
tools/perf/builtin-sched.c | 6 +-
tools/perf/builtin-stat.c | 273 ++++++++++++-----------
tools/perf/tests/topology.c | 10 +-
tools/perf/util/cpumap.c | 182 ++++++---------
tools/perf/util/cpumap.h | 102 ++++++---
tools/perf/util/cputopo.c | 2 +-
tools/perf/util/env.c | 6 +-
tools/perf/util/stat-display.c | 69 +++---
tools/perf/util/stat.c | 9 +-
tools/perf/util/stat.h | 3 +-
15 files changed, 361 insertions(+), 336 deletions(-)

--
2.34.1.400.ga245620fadb-goog

\
 
 \ /
  Last update: 2021-12-08 03:47    [W:0.887 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site