Messages in this thread Patch in this message | | | Date | Sat, 4 Dec 2021 23:28:14 +0800 | From | kernel test robot <> | Subject | [RFC PATCH t-kristo-pm] HID: bpf: hid_bpf_add_report() can be static |
| |
drivers/hid/hid-bpf.c:229:23: warning: symbol 'hid_bpf_add_report' was not declared. Should it be static? drivers/hid/hid-bpf.c:257:6: warning: symbol 'hid_bpf_free_reports' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- hid-bpf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-bpf.c b/drivers/hid/hid-bpf.c index b46b68d54ea80..6b39c48d3d85c 100644 --- a/drivers/hid/hid-bpf.c +++ b/drivers/hid/hid-bpf.c @@ -226,9 +226,9 @@ struct hid_bpf_parser_and_data { struct hid_bpf_report_enum report_enum[HID_REPORT_TYPES]; }; -struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data, - unsigned int type, unsigned int id, - unsigned int application) +static struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data, + unsigned int type, unsigned int id, + unsigned int application) { struct hid_bpf_report_enum *report_enum = data->report_enum + type; struct hid_bpf_report *report; @@ -254,7 +254,7 @@ struct hid_bpf_report *hid_bpf_add_report(struct hid_bpf_parser_and_data *data, return report; } -void hid_bpf_free_reports(struct hid_bpf_parser_and_data *data) +static void hid_bpf_free_reports(struct hid_bpf_parser_and_data *data) { unsigned i, j;
| |