lkml.org 
[lkml]   [2021]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] soundwire: intel: remove unnecessary init
On 13-12-21, 13:46, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> cppcheck warning:
>
> drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a
> value that is never used. [unreadVariable]
> int ret = 0;
> ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Reviewed-by: Rander Wang <rander.wang@intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> ---
> drivers/soundwire/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index e946d1283892..45ea55a7d0c8 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev)
> struct sdw_intel *sdw = cdns_to_intel(cdns);
> struct sdw_bus *bus = &cdns->bus;
> u32 clock_stop_quirks;
> - int ret = 0;
> + int ret;

Ideally this should not be part of this series!

If Mark wants to pick:

Acked-By: Vinod Koul <vkoul@kernel.org>

>
> if (bus->prop.hw_disabled || !sdw->startup_done) {
> dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n",
> --
> 2.17.1

--
~Vinod

\
 
 \ /
  Last update: 2021-12-23 07:59    [W:0.121 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site