lkml.org 
[lkml]   [2021]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] soundwire: intel: remove PDM support
    On Mon, Dec 13, 2021 at 01:46:34PM +0800, Bard Liao wrote:
    > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    >
    > While the hardware supports PDM streams, this capability has never
    > been tested or enabled on any product, so this is dead-code. Let's
    > remove all this.

    This doesn't build with current code, I'm guessing due to a Soundwire
    dependency I don't have:

    /mnt/kernel/drivers/soundwire/intel.c:1142:3: error: 'const struct snd_soc_dai_ops' has no member named 'set_sdw_stream'; did you mean 'set_stream'?
    1142 | .set_sdw_stream = intel_pdm_set_sdw_stream,
    | ^~~~~~~~~~~~~~
    | set_stream
    /mnt/kernel/drivers/soundwire/intel.c:1142:20: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *, struct snd_soc_dai *)' from incompatible pointer type 'int (*)(struct snd_soc_dai *, void *, int)' [-Werror=incompatible-pointer-types]
    1142 | .set_sdw_stream = intel_pdm_set_sdw_stream,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    /mnt/kernel/drivers/soundwire/intel.c:1142:20: note: (near initialization for 'intel_pdm_dai_ops.hw_params')
    /mnt/kernel/drivers/soundwire/intel.c:1143:3: error: 'const struct snd_soc_dai_ops' has no member named 'get_sdw_stream'; did you mean 'get_stream'?
    1143 | .get_sdw_stream = intel_get_sdw_stream,
    | ^~~~~~~~~~~~~~
    | get_stream
    /mnt/kernel/drivers/soundwire/intel.c:1143:20: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_soc_dai *)' from incompatible pointer type 'void * (*)(struct snd_soc_dai *, int)' [-Werror=incompatible-pointer-types]
    1143 | .get_sdw_stream = intel_get_sdw_stream,
    | ^~~~~~~~~~~~~~~~~~~~
    /mnt/kernel/drivers/soundwire/intel.c:1143:20: note: (near initialization for 'intel_pdm_dai_ops.hw_free')
    cc1: all warnings being treated as errors
    make[3]: *** [/mnt/kernel/scripts/Makefile.build:287: drivers/soundwire/intel.o] Error 1
    make[3]: *** Waiting for unfinished jobs....
    make[2]: *** [/mnt/kernel/scripts/Makefile.build:549: drivers/soundwire] Error 2
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [/mnt/kernel/Makefile:1846: drivers] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make: *** [Makefile:219: __sub-make] Error 2
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-12-23 19:28    [W:3.361 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site