Messages in this thread | | | Subject | Re: [PATCH] perf pmu: Fix event list for uncore PMUs | From | John Garry <> | Date | Tue, 21 Dec 2021 09:10:37 +0000 |
| |
On 21/12/2021 07:58, Jiri Olsa wrote: >> + /* Different names -> never duplicates */ >> + if (strcmp(alias_a->name, alias_b->name)) >> + return false; >> + if (!alias_a->pmu) >> + return true; >> + if (!alias_b->pmu) >> + return true; > nit could be: > > if (!alias_a->pmu || !alias_b->pmu) > return true; > > would be great to have more comments explaining the check >
This is just a sanity check that both strings are non-NULL as we do a strcmp() next. So would this be better:
if (!alias_a->pmu || !alias_b->pmu || !strcmp(alias_a->pmu, alias_b->pmu)) return true
?
It will spill a line.
Thanks, John
> thanks, > jirka > >> + if (!strcmp(alias_a->pmu, alias_b->pmu)) >> + return true; >> + /* uncore PMUs */
| |