Messages in this thread | | | From | Zhihao Cheng <> | Subject | [PATCH v4 00/13] Some bugfixs for ubi/ubifs | Date | Sat, 18 Dec 2021 18:34:59 +0800 |
| |
v1->v2: 1. Add new fix for ubifs, "ubifs: Fix to add refcount once page is set private" 2. Update "ubifs: Rename whiteout atomically": 1) Move inode mode in create_whiteout() 2) Don't check O_SYNC for whiteout, because it inherits from the old_dir 3) Remove useless 'synced_i_size ' assignment for whiteout, because it's always be zero. 4) Remove unused variable 'ui' in create_whiteout() 3. Update "ubifs: setflags: Make dirtied_ino_d 8 bytes aligned": 1) Align dirtied_ino_d with 8 bytes.
v2->v3: 1. Update "ubifs: Rename whiteout atomically": 1) Fix misspelling 'have already check the old dir inode' -> 'have already checked the old dir inode' 2) Fix misspelling "Whiteout don't have non-zero size" -> "Whiteout have non-zero size" 2. Update "ubifs: Fix to add refcount once page is set private" 1) Fix commit message to explain the root cause. 3. Update "ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2" 1) Add fastmap used pebs into 'ai' in for-loop, rather than in two-steps(Add pebs [pnum<UBI_FM_MAX_START] then add pebs [pnum>=UBI_FM_MAX_START] into 'ai').
v3->v4: 1. Update "ubifs: Add missing iput if do_tmpfile() failed in rename whiteout": 1) Move whiteout cleanup into do_tmpfile() according to Sascha's advice 2. Add new fix for ubifs, "ubifs: ubifs_writepage: Mark page dirty after writing inode failed"
Zhihao Cheng (13): ubifs: rename_whiteout: Fix double free for whiteout_ui->data ubifs: Fix deadlock in concurrent rename whiteout and inode writeback ubifs: Fix wrong number of inodes locked by ui_mutex in ubifs_inode comment ubifs: Add missing iput if do_tmpfile() failed in rename whiteout ubifs: Rename whiteout atomically ubifs: Fix 'ui->dirty' race between do_tmpfile() and writeback work ubifs: Rectify space amount budget for mkdir/tmpfile operations ubifs: setflags: Make dirtied_ino_d 8 bytes aligned ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock() ubifs: Fix to add refcount once page is set private ubi: fastmap: Return error code if memory allocation fails in add_aeb() ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 ubifs: ubifs_writepage: Mark page dirty after writing inode failed
drivers/mtd/ubi/fastmap.c | 63 ++++------ fs/ubifs/dir.c | 235 +++++++++++++++++++++++--------------- fs/ubifs/file.c | 26 +++-- fs/ubifs/io.c | 34 +++++- fs/ubifs/ioctl.c | 2 +- fs/ubifs/journal.c | 52 +++++++-- fs/ubifs/ubifs.h | 2 +- 7 files changed, 258 insertions(+), 156 deletions(-)
-- 2.31.1
| |