Messages in this thread Patch in this message | | | From | Jiapeng Chong <> | Subject | [PATCH] crypto: octeontx2 -Use swap() instead of swap_engines() | Date | Thu, 16 Dec 2021 15:48:14 +0800 |
| |
Fix the following coccicheck warning:
./drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1523:16-17: WARNING opportunity for swap().
Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c index 57307eac541c..9aef37972246 100644 --- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c +++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c @@ -1514,16 +1514,6 @@ int otx2_cpt_discover_eng_capabilities(struct otx2_cptpf_dev *cptpf) return ret; } -static void swap_engines(struct otx2_cpt_engines *engsl, - struct otx2_cpt_engines *engsr) -{ - struct otx2_cpt_engines engs; - - engs = *engsl; - *engsl = *engsr; - *engsr = engs; -} - int otx2_cpt_dl_custom_egrp_create(struct otx2_cptpf_dev *cptpf, struct devlink_param_gset_ctx *ctx) { @@ -1624,7 +1614,7 @@ int otx2_cpt_dl_custom_egrp_create(struct otx2_cptpf_dev *cptpf, } /* Keep SE engines at zero index */ if (engs[1].type == OTX2_CPT_SE_TYPES) - swap_engines(&engs[0], &engs[1]); + swap(engs[0], engs[1]); } mutex_lock(&eng_grps->lock); -- 2.20.1.7.g153144c
| |