lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] arch: sparc: add missing of_node_put before return
Date
From: Wang Qing <wangqing@vivo.com>

Fix following coccicheck warning:
WARNING: Function "for_each_node_by_type"
should have of_node_put() before return.

Early exits from for_each_node_by_type should decrement the
node reference counter.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
arch/sparc/kernel/prom_64.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/prom_64.c b/arch/sparc/kernel/prom_64.c
index f883a50..ed3e987
--- a/arch/sparc/kernel/prom_64.c
+++ b/arch/sparc/kernel/prom_64.c
@@ -460,8 +460,10 @@ static void *of_iterate_over_cpus(void *(*func)(struct device_node *, int, int),
}
#endif
ret = func(dp, cpuid, arg);
- if (ret)
+ if (ret) {
+ of_node_put(dp);
return ret;
+ }
}
return NULL;
}
--
2.7.4
\
 
 \ /
  Last update: 2021-12-13 10:52    [W:0.035 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site