Messages in this thread | | | Subject | Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files | From | Srinivas Kandagatla <> | Date | Wed, 1 Dec 2021 15:07:22 +0000 |
| |
On 01/12/2021 14:33, Srinivasa Rao Mandadapu wrote: >> >> >>> +enum lpass_lpi_functions { >>> + LPI_MUX_dmic1_clk, >>> + LPI_MUX_dmic1_data, >>> + LPI_MUX_dmic2_clk, >>> + LPI_MUX_dmic2_data, >>> + LPI_MUX_dmic3_clk, >>> + LPI_MUX_dmic3_data, >>> + LPI_MUX_i2s1_clk, >>> + LPI_MUX_i2s1_data, >>> + LPI_MUX_i2s1_ws, >>> + LPI_MUX_i2s2_clk, >>> + LPI_MUX_i2s2_data, >>> + LPI_MUX_i2s2_ws, >>> + LPI_MUX_qua_mi2s_data, >>> + LPI_MUX_qua_mi2s_sclk, >>> + LPI_MUX_qua_mi2s_ws, >>> + LPI_MUX_swr_rx_clk, >>> + LPI_MUX_swr_rx_data, >>> + LPI_MUX_swr_tx_clk, >>> + LPI_MUX_swr_tx_data, >>> + LPI_MUX_wsa_swr_clk, >>> + LPI_MUX_wsa_swr_data, >>> + LPI_MUX_gpio, >>> + LPI_MUX__, >>> +}; >>> + >>> +static const unsigned int gpio0_pins[] = { 0 }; >>> +static const unsigned int gpio1_pins[] = { 1 }; >>> +static const unsigned int gpio2_pins[] = { 2 }; >>> +static const unsigned int gpio3_pins[] = { 3 }; >>> +static const unsigned int gpio4_pins[] = { 4 }; >>> +static const unsigned int gpio5_pins[] = { 5 }; >>> +static const unsigned int gpio6_pins[] = { 6 }; >>> +static const unsigned int gpio7_pins[] = { 7 }; >>> +static const unsigned int gpio8_pins[] = { 8 }; >>> +static const unsigned int gpio9_pins[] = { 9 }; >>> +static const unsigned int gpio10_pins[] = { 10 }; >>> +static const unsigned int gpio11_pins[] = { 11 }; >>> +static const unsigned int gpio12_pins[] = { 12 }; >>> +static const unsigned int gpio13_pins[] = { 13 }; >> >>> >> to here are specific to sm8250, so it should not be in header file to >> start with. > > As these are common to all lpass variants.. I feel it's better to keep > in Header file.
You realize that every include of this file will add these static variables to file, in this case to pinctrl-lpass-lpi.c, pinctrl-sm8250-lpass-lpi.c and pinctrl-sc7280-lpass-lpi.c so in first file(pinctrl-lpass-lpi.c) you never use those variables in second file (pinctrl-sm8250-lpass-lpi.c)you only use up to gpio13 and in third file pinctrl-sc7280-lpass-lpi.c you could use them.
so its really bad idea to add static variables in header files.
--srini
> > And if new pins comes in later variants, we can add them incrementally, > and they will not impact existing pin numbers. > > I think in upcoming variants number of pins will not decrease. >
| |