Messages in this thread | | | Date | Mon, 8 Nov 2021 08:28:16 -0800 | Subject | Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' | From | Florian Fainelli <> |
| |
On 11/7/2021 5:34 PM, Krzysztof Wilczyński wrote: > Hi Christophe! > > [...] >> This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR long. > > Ahh. OK. Given this an option would be to: do nothing (keep current > status quo); allocate memory dynamically passing the "msi->nr" after it > has been set accordingly; use BRCM_INT_PCI_MSI_NR and waste a little bit > of space. > > Perhaps moving to using the DECLARE_BITMAP() would be fine in this case > too, at least to match style of other drivers more closely. > > Jim, Florian and Lorenzo - is this something that would be OK with you, > or you would rather keep things as they were?
I would be tempted to leave the code as-is, but if we do we are probably bound to seeing patches like Christophe's in the future to address the problem, unless we place a coverity specific comment in the source tree, which is probably frowned upon.
The addition of the BUILD_BUG_ON() is a good addition though. -- Florian
| |