Messages in this thread | | | Subject | Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' | From | Florian Fainelli <> | Date | Mon, 8 Nov 2021 15:44:52 -0800 |
| |
On 11/7/21 1:32 AM, Christophe JAILLET wrote: > The 'used' field of 'struct brcm_msi' is used as a bitmap. So it should > be declared as so (i.e. unsigned long *). > > This fixes an harmless Coverity warning about array vs singleton usage. > > This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR long. > So, while at it, document it, should it help someone in the future. > > Addresses-Coverity: "Out-of-bounds access (ARRAY_VS_SINGLETON)" > Suggested-by: Krzysztof Wilczynski <kw@linux.com> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |