lkml.org 
[lkml]   [2021]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/8] staging: vt6655: Introduce `idx` temporary variable
On Mon, Nov 01, 2021 at 02:31:59PM +0000, Karolina Drobnik wrote:
> Add a local variable to store `MISCFIFO_SYNDATA_IDX` offset.
> This change helps in shortening the lines in `rf.c` that
> are deemed too long by checkpatch.pl.
>

I started reviewing the v1 patch but I should have been reviewing this
patchset. Please don't do this. Leave the constant as a constant so
we don't have to look it up.

regards,
dan carpenter

\
 
 \ /
  Last update: 2021-11-04 13:16    [W:0.150 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site