lkml.org 
[lkml]   [2021]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v2 2/8] staging: vt6655: Use incrementation in `idx`
    On Mon, Nov 01, 2021 at 02:32:00PM +0000, Karolina Drobnik wrote:
    > Increment `idx` in a loop instead of adding the loop counter
    > `i` to do so. Thanks to this change, the cast to unsigned short
    > can be removed.
    >
    > Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
    > ---
    > drivers/staging/vt6655/rf.c | 16 ++++++++--------
    > 1 file changed, 8 insertions(+), 8 deletions(-)
    >
    > diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
    > index f195dafb6e63..c07653566d17 100644
    > --- a/drivers/staging/vt6655/rf.c
    > +++ b/drivers/staging/vt6655/rf.c
    > @@ -700,11 +700,11 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char rf_type,
    > return false;
    >
    > for (i = 0; i < CB_AL2230_INIT_SEQ; i++)
    > - MACvSetMISCFifo(priv, (unsigned short)(idx + i), al2230_init_table[i]);
    > + MACvSetMISCFifo(priv, idx++, al2230_init_table[i]);

    The cast was always pointless. You can remove it without any other
    changes.

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2021-11-04 13:16    [W:4.048 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site