lkml.org 
[lkml]   [2021]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>
On Wed, 03 Nov 2021, Sebastian Reichel wrote:

> Hi,
>
> On Wed, Nov 03, 2021 at 07:43:51AM +0000, Lee Jones wrote:
> > On Tue, 02 Nov 2021, Jonathan Corbet wrote:
> > > Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed the last
> > > file to include <linux/jz4740-adc.h> but left the header file itself
> > > behind. Nothing uses it, remove it now.
> > >
> > > Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740 driver")
> > > deleted the last use of <linux/power/jz4740-battery.h>, so remove that one
> > > too.
>
> Thanks for the cleanup Jonathan.
>
> > > Cc: Paul Cercueil <paul@crapouillou.net>
> > > Cc: Lee Jones <lee.jones@linaro.org>
> > > Cc: Paul Burton <paul.burton@mips.com>
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: linux-pm@vger.kernel.org
> > > Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> > > ---
> > > include/linux/jz4740-adc.h | 33 ----------------------------
> > > include/linux/power/jz4740-battery.h | 15 -------------
> >
> > It appears as though there are still references to both of these
> > *devices* in the kernel tree. Should those be removed also?
> >
> > > 2 files changed, 48 deletions(-)
> > > delete mode 100644 include/linux/jz4740-adc.h
> > > delete mode 100644 include/linux/power/jz4740-battery.h
> >
> > Patch looks fine though.
> >
> > Let me know if you want me to take it in via MFD. Otherwise:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> You can take it through MFD, no immutable branch needed.
>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Okay, no problem.

Since the merge-window is already open, we'll aim for v5.17.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2021-11-04 09:32    [W:0.059 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site