lkml.org 
[lkml]   [2021]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>
Hi Lee,

Le mer., nov. 3 2021 at 07:43:51 +0000, Lee Jones
<lee.jones@linaro.org> a écrit :
> On Tue, 02 Nov 2021, Jonathan Corbet wrote:
>
>> Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed
>> the last
>> file to include <linux/jz4740-adc.h> but left the header file itself
>> behind. Nothing uses it, remove it now.
>>
>> Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740
>> driver")
>> deleted the last use of <linux/power/jz4740-battery.h>, so remove
>> that one
>> too.
>>
>> Cc: Paul Cercueil <paul@crapouillou.net>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Paul Burton <paul.burton@mips.com>
>> Cc: Sebastian Reichel <sre@kernel.org>
>> Cc: linux-pm@vger.kernel.org
>> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
>> ---
>> include/linux/jz4740-adc.h | 33
>> ----------------------------
>> include/linux/power/jz4740-battery.h | 15 -------------
>
> It appears as though there are still references to both of these
> *devices* in the kernel tree. Should those be removed also?

These files were for older drivers that were since then replaced by
newer drivers; JZ47xx SoCs are still officially supported and
maintained.

Cheers,
-Paul

>> 2 files changed, 48 deletions(-)
>> delete mode 100644 include/linux/jz4740-adc.h
>> delete mode 100644 include/linux/power/jz4740-battery.h
>
> Patch looks fine though.
>
> Let me know if you want me to take it in via MFD. Otherwise:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2021-11-03 10:29    [W:0.075 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site