lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 2/2] irqchip: Add Qualcomm MPM controller driver
On Tue, 30 Nov 2021 02:31:52 +0000,
Shawn Guo <shawn.guo@linaro.org> wrote:
>
> + Maulik
>
> On Mon, Nov 29, 2021 at 03:24:39PM +0000, Marc Zyngier wrote:
> [...]
> > > > > @@ -430,6 +430,14 @@ config QCOM_PDC
> > > > > Power Domain Controller driver to manage and configure wakeup
> > > > > IRQs for Qualcomm Technologies Inc (QTI) mobile chips.
> > > > >
> > > > > +config QCOM_MPM
> > > > > + bool "QCOM MPM"
> > > >
> > > > Can't be built as a module?
> > >
> > > The driver is implemented as a builtin_platform_driver().
> >
> > This, on its own, shouldn't preclude the driver from being built as a
> > module. However, the config option only allows it to be built in. Why?
>
> I just tried to build it as a module, and it seems that "irq_to_desc" is
> only available for built-in build.

Yet another thing that you should not be using. The irqdomain code
gives you everything you need without having to resort to the
internals of the core IRQ infrastructure.

> > Furthermore, why would you look up anywhere other than the wake-up
> > domain? My impression was that only these interrupts would require
> > being re-triggered.
>
> Both domains have MPM pins that could wake up system.

Then why do you need two domains?

M.

--
Without deviation from the norm, progress is not possible.
\
 
 \ /
  Last update: 2021-11-30 09:43    [W:0.136 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site