lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/2] irqchip: Add Qualcomm MPM controller driver
From
Hi,

On 11/30/2021 2:01 PM, Shawn Guo wrote:
>> This can be converted to read poll_timeout(). This was introduced in
>> place of wmb() to make sure writes are completed.
> Hmm, in this case, writel() will just do the right thing, as it wraps
> wmb() there. Or am I missing something?
>
> Shawn
#define writel(v,c)             ({ __iowmb(); writel_relaxed((v),(c)); })

writel() does not do wmb() after writel_relaxed(), it does before.

we need to make sure write is propagated, so wmb() or read  back with
timeout need to be kept after writel() is done.

Thanks,
Maulik

\
 
 \ /
  Last update: 2021-11-30 09:55    [W:1.043 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site