Messages in this thread | | | Date | Wed, 3 Nov 2021 07:32:28 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error |
| |
On Tue, 02 Nov 2021, Michael Walle wrote:
> Am 2021-11-02 12:17, schrieb Lee Jones: > > On Tue, 02 Nov 2021, Robert Marko wrote: > > > > > MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build > > > error: > > > > > > aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function > > > `simple_mfd_i2c_probe': > > > drivers/mfd/simple-mfd-i2c.c:55: undefined reference to > > > `devm_mfd_add_devices' > > > > What is your use-case? > > > > How are you enabling this symbol? > > Mh? drivers/mfd/simple-mfd-i2c.c is using devm_mfd_add_devices which > is provided by drivers/mfd/core.c. So select MFD_CORE is clearly > missing here, no? I mean most of the MFD drivers do a "select MFD_CORE".
I'm not debating that. The patch is fine.
I am however, interested in how MFD_CORE is enabled for MFD_SL28CPLD.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |