Messages in this thread | | | Date | Wed, 3 Nov 2021 07:33:16 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error |
| |
On Tue, 02 Nov 2021, Robert Marko wrote:
> On Tue, Nov 2, 2021 at 12:35 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Tue, 02 Nov 2021, Robert Marko wrote: > > > > > On Tue, Nov 2, 2021 at 12:17 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > On Tue, 02 Nov 2021, Robert Marko wrote: > > > > > > > > > MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build error: > > > > > > > > > > aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > > > > > drivers/mfd/simple-mfd-i2c.c:55: undefined reference to `devm_mfd_add_devices' > > > > > > > > What is your use-case? > > > > > > > > How are you enabling this symbol? > > > > > > Hi Lee, > > > I am adding a symbol like MFD_SL28CPLD does that you can depend on and > > > that simply > > > selects the MFD_SIMPLE_MFD_I2C and I have hit this issue since the > > > MFD_CORE is not selected. > > > > That's interesting. > > > > I wonder how MFD_SL28CPLD selects it? > > It doesn't, it just selects MFD_SIMPLE_MFD_I2C > > MFD_CORE is probably selected by something else masking this issue.
Right. That's what I'm trying to get to the bottom of.
Don't worry, the patch will be accepted.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |