Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()' | Date | Sun, 28 Nov 2021 12:03:30 +0100 |
| |
The 'dest' bitmap is fully initialized by the 'for' loop, so there is no need to explicitly reset it.
This also makes this function in line with 'ethnl_features_to_bitmap32()' which does not clear the destination before writing it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- net/ethtool/features.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/net/ethtool/features.c b/net/ethtool/features.c index 1c9f4df273bd..2e7331b23996 100644 --- a/net/ethtool/features.c +++ b/net/ethtool/features.c @@ -136,7 +136,6 @@ static void ethnl_features_to_bitmap(unsigned long *dest, netdev_features_t val) const unsigned int words = BITS_TO_LONGS(NETDEV_FEATURE_COUNT); unsigned int i; - bitmap_zero(dest, NETDEV_FEATURE_COUNT); for (i = 0; i < words; i++) dest[i] = (unsigned long)(val >> (i * BITS_PER_LONG)); } -- 2.30.2
| |