lkml.org 
[lkml]   [2021]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 12/12] gpio: Add support for Airoha EN7523 GPIO controller
On Fri, Nov 26, 2021 at 6:40 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Thu, Nov 25, 2021 at 12:24 PM Felix Fietkau <nbd@nbd.name> wrote:
> >
> > From: John Crispin <john@phrozen.org>
> >
> > Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32
> > GPIOs. Each instance in DT is for an single bank.

a single

...

> > + err = bgpio_init(&ctrl->gc, dev, 4, ctrl->data, NULL,
> > + NULL, NULL, NULL, 0);
> > + if (err) {
> > + dev_err(dev, "unable to init generic GPIO");
> > + return err;
> > + }

Since it will be a new version you may have a chance to replace this with

return dev_err_probe(dev, err, ...);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-11-26 18:27    [W:0.312 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site