Messages in this thread | | | Date | Thu, 25 Nov 2021 18:46:46 +0100 | Subject | Re: [PATCH 3/4] staging: r8188eu: remove _ps_close_RF | From | Michael Straube <> |
| |
On 11/25/21 17:47, Martin Kaiser wrote: > The _ps_close_RF is empty. Remove it. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index 995ea4a55435..0b1aaa162c21 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -850,12 +850,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) > return status; > } > > -static void _ps_close_RF(struct adapter *adapt) > -{ > - /* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */ > - /* phy_SsPwrSwitch92CU(adapt, rf_off, 1); */ > -} > - > static void CardDisableRTL8188EU(struct adapter *Adapter) > { > u8 val8; > @@ -921,9 +915,7 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter) > rtw_write32(Adapter, REG_HIMRE_88E, IMR_DISABLED_88E); > > DBG_88E("bkeepfwalive(%x)\n", Adapter->pwrctrlpriv.bkeepfwalive); > - if (Adapter->pwrctrlpriv.bkeepfwalive) { > - _ps_close_RF(Adapter); > - } else { > + if (!Adapter->pwrctrlpriv.bkeepfwalive) { > if (Adapter->hw_init_completed) { > CardDisableRTL8188EU(Adapter); > } >
Reviewed-by: Michael Straube <straube.linux@gmail.com>
| |