lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] staging: r8188eu: remove _ps_close_RF
From
On 11/25/21 17:47, Martin Kaiser wrote:
> The _ps_close_RF is empty. Remove it.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 995ea4a55435..0b1aaa162c21 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -850,12 +850,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
> return status;
> }
>
> -static void _ps_close_RF(struct adapter *adapt)
> -{
> - /* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
> - /* phy_SsPwrSwitch92CU(adapt, rf_off, 1); */
> -}
> -
> static void CardDisableRTL8188EU(struct adapter *Adapter)
> {
> u8 val8;
> @@ -921,9 +915,7 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter)
> rtw_write32(Adapter, REG_HIMRE_88E, IMR_DISABLED_88E);
>
> DBG_88E("bkeepfwalive(%x)\n", Adapter->pwrctrlpriv.bkeepfwalive);
> - if (Adapter->pwrctrlpriv.bkeepfwalive) {
> - _ps_close_RF(Adapter);
> - } else {
> + if (!Adapter->pwrctrlpriv.bkeepfwalive) {
> if (Adapter->hw_init_completed) {
> CardDisableRTL8188EU(Adapter);
> }
>

Reviewed-by: Michael Straube <straube.linux@gmail.com>

\
 
 \ /
  Last update: 2021-11-25 18:58    [W:0.641 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site