lkml.org 
[lkml]   [2021]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] staging: r8188eu: remove _ps_open_RF
From
On 11/25/21 17:47, Martin Kaiser wrote:
> The _ps_open_RF function is empty. Remove it.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 04518e9838ea..995ea4a55435 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -615,8 +615,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
> HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_BEGIN);
>
> if (Adapter->pwrctrlpriv.bkeepfwalive) {
> - _ps_open_RF(Adapter);
> -
> if (haldata->odmpriv.RFCalibrateInfo.bIQKInitialized) {
> PHY_IQCalibrate_8188E(Adapter, true);
> } else {
> @@ -852,12 +850,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
> return status;
> }
>
> -void _ps_open_RF(struct adapter *adapt)
> -{
> - /* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
> - /* phy_SsPwrSwitch92CU(adapt, rf_on, 1); */
> -}
> -
> static void _ps_close_RF(struct adapter *adapt)
> {
> /* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
>

Hi Martin,

The prototype of _ps_open_RF() should also be removed from
rtl8188e_hal.h.

Thanks,
Michael

\
 
 \ /
  Last update: 2021-11-25 18:58    [W:0.087 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site