lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] tracing/uprobe: Fix uprobe_perf_open probes iteration
On Wed, Nov 24, 2021 at 10:30:24AM -0800, Linus Torvalds wrote:
> On Wed, Nov 24, 2021 at 10:27 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Instead, you should do something like
> >
> > list_for_each_entry(pu, trace_probe_probe_list(tp), tp.list) {
>
> That 'pu' is a typo, it should be 'tu'.
>
> The patch itself got it right, I think.
>
> HOWEVER. Despite the patch itself getting it right, I want to point
> out that that was mostly by luck than anything else.
>
> The patch is ENTIRELY UNTESTED.

I put your patch to the test and.. it passed ;-)

there are several other places like this around and also in trace_kprobe.c
I can send the follow up fix tomorrow

thanks,
jirka

>
> Because that's how I roll, as you should all know by now.
>
> Linus
>

\
 
 \ /
  Last update: 2021-11-24 21:06    [W:0.333 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site