Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 24 Nov 2021 10:30:24 -0800 | Subject | Re: [GIT PULL] tracing/uprobe: Fix uprobe_perf_open probes iteration |
| |
On Wed, Nov 24, 2021 at 10:27 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Instead, you should do something like > > list_for_each_entry(pu, trace_probe_probe_list(tp), tp.list) {
That 'pu' is a typo, it should be 'tu'.
The patch itself got it right, I think.
HOWEVER. Despite the patch itself getting it right, I want to point out that that was mostly by luck than anything else.
The patch is ENTIRELY UNTESTED.
Because that's how I roll, as you should all know by now.
Linus
| |