Messages in this thread Patch in this message | | | From | Geert Uytterhoeven <> | Subject | [PATCH] regulator: lp873x: Use bitfield helpers | Date | Mon, 22 Nov 2021 16:54:08 +0100 |
| |
Use the FIELD_PREP() helper, instead open-coding the same operation.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Compile-tested only.
See "[PATCH 00/17] Non-const bitfield helper conversions" (https://lore.kernel.org/r/cover.1637592133.git.geert+renesas@glider.be) for background and more conversions. --- drivers/regulator/lp873x-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/lp873x-regulator.c b/drivers/regulator/lp873x-regulator.c index c38387e0fbb2a33d..f1f5be7b54cd9e90 100644 --- a/drivers/regulator/lp873x-regulator.c +++ b/drivers/regulator/lp873x-regulator.c @@ -13,6 +13,7 @@ * GNU General Public License version 2 for more details. */ +#include <linux/bitfield.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/regmap.h> @@ -101,7 +102,7 @@ static int lp873x_buck_set_ramp_delay(struct regulator_dev *rdev, ret = regmap_update_bits(lp873->regmap, regulators[id].ctrl2_reg, LP873X_BUCK0_CTRL_2_BUCK0_SLEW_RATE, - reg << __ffs(LP873X_BUCK0_CTRL_2_BUCK0_SLEW_RATE)); + FIELD_PREP(LP873X_BUCK0_CTRL_2_BUCK0_SLEW_RATE, reg)); if (ret) { dev_err(lp873->dev, "SLEW RATE write failed: %d\n", ret); return ret; -- 2.25.1
| |