Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 16 Nov 2021 18:13:04 +0200 | Subject | Re: [PATCH v4 00/16] Basic StarFive JH7100 RISC-V SoC support |
| |
On Tue, Nov 16, 2021 at 6:09 PM Arnd Bergmann <arnd@arndb.de> wrote: > On Tue, Nov 16, 2021 at 4:01 PM Emil Renner Berthing <kernel@esmil.dk> wrote:
...
> One general (minor) comment about the patches: please put your own > 'Signed-off-by' > into the last line of the patch description, below all the lines you > took from other people, so > instead of: > > | Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > | Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > | Acked-by: Rob Herring <robh@kernel.org> > > do this: > > | Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > | Acked-by: Rob Herring <robh@kernel.org> > | Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Why? Submitting Patches tells about chronological order and last SoB to be from the submitter. These both are correct. Note the difference between 'last SoB' and 'SoB to be last [line]'.
Here is the excerpt: "Notably, the last Signed-off-by: must always be that of the developer submitting the patch."
-- With Best Regards, Andy Shevchenko
| |