Messages in this thread | | | Date | Tue, 16 Nov 2021 11:55:23 +0000 | From | Daniel Thompson <> | Subject | Re: [PATCH v2] backlight: ili922x: fix kernel-doc warnings & notation |
| |
On Mon, Nov 15, 2021 at 06:33:55PM -0800, Randy Dunlap wrote: > Convert function-like macro comments to kernel-doc notation and > fix other kernel-doc warnings: > > drivers/video/backlight/ili922x.c:85: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * START_BYTE(id, rs, rw) > drivers/video/backlight/ili922x.c:118: warning: expecting prototype for CHECK_FREQ_REG(spi_device s, spi_transfer x)(). Prototype was for CHECK_FREQ_REG() instead > > ili922x.c:92: warning: contents before sections > ili922x.c:150: warning: No description found for return value of 'ili922x_read_status' > ili922x.c:193: warning: No description found for return value of 'ili922x_read' > ili922x.c:247: warning: No description found for return value of 'ili922x_write' > ili922x.c:353: warning: No description found for return value of 'ili922x_poweron' > ili922x.c:382: warning: No description found for return value of 'ili922x_poweroff' > > Fixes: 4cfbfa971478 ("video: backlight: add ili922x lcd driver") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: dri-devel@lists.freedesktop.org > Cc: Stefano Babic <sbabic@denx.de> > Cc: Anatolij Gustschin <agust@denx.de> > --- > v2: add periods at end of sentences so that the generated documentation > flows correctly. (thanks, Daniel)
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
| |