Messages in this thread Patch in this message | | | From | Leon Romanovsky <> | Subject | [PATCH net] devlink: Remove extra assertion from flash notification logic | Date | Mon, 15 Nov 2021 20:07:47 +0200 |
| |
From: Leon Romanovsky <leonro@nvidia.com>
The mlxsw driver calls to various devlink flash routines even before users can get any access to the devlink instance itself. For example, mlxsw_core_fw_rev_validate() one of such functions.
It causes to the WARN_ON to trigger warning about devlink not registered, while the flow is valid.
Fixes: cf530217408e ("devlink: Notify users when objects are accessible") Reported-by: Amit Cohen <amcohen@nvidia.com> Tested-by: Amit Cohen <amcohen@nvidia.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> --- net/core/devlink.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c index 5ba4f9434acd..6face738b16a 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -4229,7 +4229,6 @@ static void __devlink_flash_update_notify(struct devlink *devlink, WARN_ON(cmd != DEVLINK_CMD_FLASH_UPDATE && cmd != DEVLINK_CMD_FLASH_UPDATE_END && cmd != DEVLINK_CMD_FLASH_UPDATE_STATUS); - WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED)); msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); if (!msg) -- 2.33.1
| |