Messages in this thread | | | Subject | Re: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko | From | Daniel Baluta <> | Date | Wed, 10 Nov 2021 17:27:26 +0200 |
| |
On 11/8/21 1:11 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is > not built into a the main SOF driver when that is built-in: > > x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message': > ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed' > x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load': > topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work' > x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work' > > Make this a 'bool' symbol so it just decides whether the > code gets built at all. > > Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Indeed this is a bug and must be fixed. Thanks Arnd!
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> --- > sound/soc/sof/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig > index 6bb4db87af03..041c54639c4d 100644 > --- a/sound/soc/sof/Kconfig > +++ b/sound/soc/sof/Kconfig > @@ -47,7 +47,7 @@ config SND_SOC_SOF_OF > Say Y if you need this option. If unsure select "N". > > config SND_SOC_SOF_COMPRESS > - tristate > + bool > select SND_SOC_COMPRESS > > config SND_SOC_SOF_DEBUG_PROBES
| |