Messages in this thread | | | Subject | Re: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko | From | Pierre-Louis Bossart <> | Date | Mon, 8 Nov 2021 07:39:29 -0600 |
| |
On 11/8/21 5:11 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is > not built into a the main SOF driver when that is built-in: > > x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message': > ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed' > x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load': > topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work' > x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work' > > Make this a 'bool' symbol so it just decides whether the > code gets built at all. > > Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
It's Monday morning and my memory is still foggy but I think we fixed this problem with https://github.com/thesofproject/linux/pull/3180, where we changed the Kconfigs for i.MX. We haven't sent this update upstream for some reason.
Arnd, can you share the configuration that breaks with the existing upstream code, I can check if the problem still exists.
Thanks!
| |