lkml.org 
[lkml]   [2021]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] mtd: Ingenic NAND fix for JZ4740
Date
Hi,

Looks like NAND support has been broken on the JZ4740 SoC for a while;
it looks like it comes from the fact that the "hw_oob_first" mechanism
was dropped from the NAND core and moved to the Davinci driver.

It turns out the JZ4740 SoC needs it too; I didn't notice it when
writing the new ingenic-nand driver (to replace the old jz4740-nand
driver) most likely because my Device Tree had the "nand-ecc-mode" set
to "hw_oob_first".

I am not very sure about patch [1/3]; to me the original code does not
make sense, and it didn't work out-of-the-box on the JZ4740 without it.
By applying patch [1/3] the function nand_read_page_hwecc_oob_first()
can be reused for the JZ4740 SoC as well. But I did not test patch [1/3]
on Davinci.

Cheers,
-Paul

Paul Cercueil (3):
mtd: rawnand/davinci: Don't calculate ECC when reading page
mtd: rawnand: Export nand_read_page_hwecc_oob_first()
mtd: rawnand/ingenic: JZ4740 needs 'oob_first' read page function

drivers/mtd/nand/raw/davinci_nand.c | 73 +------------------
.../mtd/nand/raw/ingenic/ingenic_nand_drv.c | 5 ++
drivers/mtd/nand/raw/nand_base.c | 69 ++++++++++++++++++
include/linux/mtd/rawnand.h | 2 +
4 files changed, 77 insertions(+), 72 deletions(-)

--
2.33.0

\
 
 \ /
  Last update: 2021-10-09 20:51    [W:0.072 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site