lkml.org 
[lkml]   [2021]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 02/10] cxl/pci: Remove dev_dbg for unknown register blocks
From
Date
On Sat, 2021-10-09 at 09:44 -0700, Dan Williams wrote:
> From: Ben Widawsky <ben.widawsky@intel.com>
>
> While interesting to driver developers, the dev_dbg message doesn't do
> much except clutter up logs.

So? This isn't enabled by default. How does it 'clutter' logs?

> This information should be attainable
> through sysfs, and someday lspci like utilities. This change
> additionally helps reduce the LOC in a subsequent patch to refactor some
> of cxl_pci register mapping.
>
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/cxl/pci.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 64180f46c895..ccc7c2573ddc 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -475,9 +475,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
>   cxl_decode_register_block(reg_lo, reg_hi, &bar, &offset,
>   &reg_type);
>  
>
> - dev_dbg(dev, "Found register block in bar %u @ 0x%llx of type %u\n",
> - bar, offset, reg_type);
> -
>   /* Ignore unknown register block types */
>   if (reg_type > CXL_REGLOC_RBI_MEMDEV)
>   continue;
>


\
 
 \ /
  Last update: 2021-10-09 18:48    [W:0.175 / U:2.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site