Messages in this thread | | | Date | Wed, 13 Oct 2021 15:45:23 -0700 | From | Ben Widawsky <> | Subject | Re: [PATCH v3 07/10] cxl/pci: Split cxl_pci_setup_regs() |
| |
On 21-10-09 09:44:34, Dan Williams wrote: > From: Ben Widawsky <ben.widawsky@intel.com> > > In preparation for moving parts of register mapping to cxl_core, split > cxl_pci_setup_regs() into a helper that finds register blocks, > (cxl_find_regblock()), and a generic wrapper that probes the precise > register sets within a block (cxl_setup_regs()). > > Move the actual mapping (cxl_map_regs()) of the only register-set that > cxl_pci cares about (memory device registers) up a level from the former > cxl_pci_setup_regs() into cxl_pci_probe(). > > With this change the unused component registers are no longer mapped, > but the helpers are primed to move into the core. > > Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> > [djbw: rebase on the cxl_register_map refactor] > [djbw: drop cxl_map_regs() for component registers] > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
[snip]
Did you mean to also drop the component register handling in cxl_probe_regs() and cxl_map_regs()?
| |