Messages in this thread | | | From | Hans de Goede <> | Subject | [PATCH 00/12] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data | Date | Fri, 8 Oct 2021 18:21:09 +0200 |
| |
Hi All,
This patch series is a rework/rewrite of Daniel Scally's earlier attempts at adding support for camera sensor connected to a TPS68470 PMIC on x86/ACPI devices.
The clk and regulator frameworks expect clk/regulator consumer-devices to have info about the consumed clks/regulators described in the device's fw_node, but on ACPI this info is missing.
This series worksaround this by providing platform_data with the info to the TPS68470 clk/regulator MFD cells.
Patches 1 - 3 deal with a probe-ordering problem this introduces, since the lookups are only registered when the provider-driver binds, trying to get these clks/regulators before then results in a -ENOENT error for clks and a dummy regulator for regulators. See the patches for more details.
Patch 4 adds a header file which adds tps68470_clk_platform_data and tps68470_regulator_platform_data structs. The futher patches depend on this new header file.
Patch 5 + 6 add the TPS68470 clk and regulator drivers
Patches 7 - 12 Modify the INT3472 driver which instantiates the MFD cells to provide the necessary platform-data.
Assuming this series is acceptable to everyone, we need to talk about how to merge this.
Rafael, can you provide an immutable branch with "[PATCH 01/12] ACPI: Add has_unmet_acpi_deps() helper function" on there? Then the media subsys-maintaines can merge that and then merge patch 2 + 3 on top.
For "[PATCH 04/12] platform_data: Add linux/platform_data/tps68470.h file", which all further patches depend on I plan to provide an immutable branch myself (once it has been reviewed), which the clk / regulator maintainers can then merge before merging the clk / regulator driver which depends on this.
Regards,
Hans
Daniel Scally (1): platform/x86: int3472: Enable I2c daisy chain
Hans de Goede (11): ACPI: Add has_unmet_acpi_deps() helper function media: i2c: ov8865: Add an has_unmet_acpi_deps() check media: i2c: ov5693: Add an has_unmet_acpi_deps() check platform_data: Add linux/platform_data/tps68470.h file regulator: Introduce tps68470-regulator driver clk: Introduce clk-tps68470 driver platform/x86: int3472: Split into 2 drivers platform/x86: int3472: Add get_sensor_adev_and_name() helper platform/x86: int3472: Pass tps68470_clk_platform_data to the tps68470-regulator MFD-cell platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell platform/x86: int3472: Call acpi_dev_clear_dependencies() on successful probe
drivers/clk/Kconfig | 6 + drivers/clk/Makefile | 1 + drivers/clk/clk-tps68470.c | 257 ++++++++++++++++++ drivers/media/i2c/ov5693.c | 3 + drivers/media/i2c/ov8865.c | 3 + drivers/platform/x86/intel/int3472/Makefile | 9 +- ...lk_and_regulator.c => clk_and_regulator.c} | 2 +- drivers/platform/x86/intel/int3472/common.c | 82 ++++++ .../{intel_skl_int3472_common.h => common.h} | 6 +- ...ntel_skl_int3472_discrete.c => discrete.c} | 51 ++-- .../intel/int3472/intel_skl_int3472_common.c | 106 -------- ...ntel_skl_int3472_tps68470.c => tps68470.c} | 88 +++++- drivers/platform/x86/intel/int3472/tps68470.h | 25 ++ .../x86/intel/int3472/tps68470_board_data.c | 118 ++++++++ drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/tps68470-regulator.c | 194 +++++++++++++ include/linux/acpi.h | 12 + include/linux/mfd/tps68470.h | 11 + include/linux/platform_data/tps68470.h | 35 +++ 20 files changed, 873 insertions(+), 146 deletions(-) create mode 100644 drivers/clk/clk-tps68470.c rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_clk_and_regulator.c => clk_and_regulator.c} (99%) create mode 100644 drivers/platform/x86/intel/int3472/common.c rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_common.h => common.h} (94%) rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_discrete.c => discrete.c} (91%) delete mode 100644 drivers/platform/x86/intel/int3472/intel_skl_int3472_common.c rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_tps68470.c => tps68470.c} (58%) create mode 100644 drivers/platform/x86/intel/int3472/tps68470.h create mode 100644 drivers/platform/x86/intel/int3472/tps68470_board_data.c create mode 100644 drivers/regulator/tps68470-regulator.c create mode 100644 include/linux/platform_data/tps68470.h
-- 2.31.1
| |