Messages in this thread | | | Subject | Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file | From | Lu Baolu <> | Date | Fri, 8 Oct 2021 12:34:57 +0800 |
| |
Hi Andy,
On 10/7/21 12:14 AM, Andy Shevchenko wrote: > On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote: >> Hi Andy, >> >> On 7/30/21 12:35 AM, Andy Shevchenko wrote: >>> Compiler is not happy about hidden declaration of intel_iommu_ops. >>> >>> .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static? >>> >>> Move declaration to header file to make compiler happy. >> >> Thanks for the cleanup. Sharing data structures between different files >> doesn't seem to be a good design. How about adding a helper so that the >> intel_iommu_ops could be a static one? > > I don't see any change in the upstream. What's the plan? > Can we take my patch as a quick fix? >
Thanks for the reminding.
Can you please tell in which kernel configuration could above warning be triggered?
Best regards, baolu
| |