lkml.org 
[lkml]   [2021]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file
On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote:
> On 7/30/21 12:35 AM, Andy Shevchenko wrote:
> > Compiler is not happy about hidden declaration of intel_iommu_ops.
> >
> > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static?
> >
> > Move declaration to header file to make compiler happy.
>
> Thanks for the cleanup. Sharing data structures between different files
> doesn't seem to be a good design. How about adding a helper so that the
> intel_iommu_ops could be a static one?

Whatever suits the purpose.
Can you apply patch 2 of this series, please?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-07-30 10:06    [W:0.085 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site