Messages in this thread | | | From | Nicolai Stange <> | Subject | [PATCH 0/8] crypto: api - priorize tested algorithms in lookup | Date | Sun, 3 Oct 2021 20:14:05 +0200 |
| |
Hi all,
my initial goal had been to make the algorithm lookup prefer usable instances over ones where the tests are still pending. In my first attempt I realized that the code in crypto_alg_lookup() became quite convoluted and that it could get streamlined somewhat by consolidating CRYPTO_ALG_TESTED handling for lookup larvals a bit.
This cleanup can be found in [1/8] - [7/8] and might perhaps be worth considering on its own, independent of whether or not you deem the final [8/8], the patch implementing my original goal of priorizing algorithms in working state, suitable for upstream inclusion.
This series is based on current herbert/cryptodev-2.6 master.
All patches have been tested with tcrypt.ko as well as the kernel/crypto testcases from LTP.
Thanks!
Nicolai
Nicolai Stange (8): crypto: af_alg - reject requests for untested algorithms crypto: user - reject requests for untested algorithms crypto: api - only support lookups for specific CRYPTO_ALG_TESTED status crypto: api - don't add larvals for !(type & CRYPTO_ALG_TESTED) lookups crypto: api - always set CRYPTO_ALG_TESTED in lookup larvals' ->mask/type crypto: api - make crypto_alg_lookup() consistently check for failed algos crypto: api - lift common mask + type adjustment to crypto_larval_lookup() crypto: api - make the algorithm lookup priorize non-larvals
crypto/af_alg.c | 9 +++++++ crypto/api.c | 53 ++++++++++++++++++++++++++++++++------- crypto/crypto_user_base.c | 3 +++ 3 files changed, 56 insertions(+), 9 deletions(-)
-- 2.26.2
| |