Messages in this thread | | | Date | Tue, 26 Oct 2021 12:26:14 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH V5 08/20] rtla: Helper functions for rtla |
| |
On Wed, 27 Oct 2021 00:22:04 +0800 Tao Zhou <tao.zhou@linux.dev> wrote:
> > + do { > > + retval = read(in_fd, buffer, sizeof(buffer)); > > + if (read <= 0) > > check "retval" not read. Like: > > if (retval <= 0)
OUCH! Good check.
Daniel, did that not produce any warnings??
-- Steve
> > > + goto out_close; > > + > > + retval = write(out_fd, buffer, retval); > > + if (retval < 0) > > + goto out_close; > > + } while (retval > 0);
| |