lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V5 08/20] rtla: Helper functions for rtla
From
On 10/26/21 18:26, Steven Rostedt wrote:
> On Wed, 27 Oct 2021 00:22:04 +0800
> Tao Zhou <tao.zhou@linux.dev> wrote:
>
>>> + do {
>>> + retval = read(in_fd, buffer, sizeof(buffer));
>>> + if (read <= 0)
>> check "retval" not read. Like:
>>
>> if (retval <= 0)
> OUCH! Good check.
>
> Daniel, did that not produce any warnings??

OUCH OUCH!

No warnings, no nothing.

The code actually "works" because errors are not common and the next if stops
the loop.

-- Daniel

> -- Steve
>
>

\
 
 \ /
  Last update: 2021-10-26 21:46    [W:0.066 / U:1.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site