Messages in this thread Patch in this message | | | Date | Tue, 26 Oct 2021 10:16:09 -0000 | From | "irqchip-bot for Mark Rutland" <> | Subject | [irqchip: irq/irqchip-next] irq: mips: simplify bcm6345_l1_irq_handle() |
| |
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 46b61c88e1075829103874c95f13160e3b9e1618 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/46b61c88e1075829103874c95f13160e3b9e1618 Author: Mark Rutland <mark.rutland@arm.com> AuthorDate: Fri, 22 Oct 2021 15:27:06 +01:00 Committer: Mark Rutland <mark.rutland@arm.com> CommitterDate: Mon, 25 Oct 2021 10:04:53 +01:00
irq: mips: simplify bcm6345_l1_irq_handle()
As bcm6345_l1_irq_handle() only needs to know /whether/ an IRQ was resolved, and doesn't need to know the specific IRQ, it's simpler for it to call generic_handle_domain_irq() directly and check the return code, so let's do that.
There should be no functional change as a result of this patch.
Signed-off-by: Mark Rutland <mark.rutland@arm.com> Suggested-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Marc Zyngier <maz@kernel.org> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Thomas Gleixner <tglx@linutronix.de> --- drivers/irqchip/irq-bcm6345-l1.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-bcm6345-l1.c b/drivers/irqchip/irq-bcm6345-l1.c index 1bd0621..fd07921 100644 --- a/drivers/irqchip/irq-bcm6345-l1.c +++ b/drivers/irqchip/irq-bcm6345-l1.c @@ -132,16 +132,12 @@ static void bcm6345_l1_irq_handle(struct irq_desc *desc) int base = idx * IRQS_PER_WORD; unsigned long pending; irq_hw_number_t hwirq; - unsigned int irq; pending = __raw_readl(cpu->map_base + reg_status(intc, idx)); pending &= __raw_readl(cpu->map_base + reg_enable(intc, idx)); for_each_set_bit(hwirq, &pending, IRQS_PER_WORD) { - irq = irq_linear_revmap(intc->domain, base + hwirq); - if (irq) - generic_handle_irq(irq); - else + if (generic_handle_domain_irq(intc->domain, base + hwirq)) spurious_interrupt(); } }
| |