Messages in this thread | | | Subject | Re: [PATCH v7 2/4] iio: adc: Add Xilinx AMS driver | From | Lars-Peter Clausen <> | Date | Tue, 26 Oct 2021 09:09:44 +0200 |
| |
On 10/19/21 5:20 PM, Anand Ashok Dumbre wrote: > [...] > +#define AMS_CHAN_TEMP(_scan_index, _addr) { \ > + .type = IIO_TEMP, \ > + .indexed = 1, \ > + .address = (_addr), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_SCALE) | \ > + BIT(IIO_CHAN_INFO_OFFSET), \ > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \ There is no handling of IIO_CHAN_INFO_SAMP_FREQ in read_raw(). Reading the sampling_frequency attribute always returns -EINVAL. > + .event_spec = ams_temp_events, \ > + .scan_index = _scan_index, \ > + .num_event_specs = ARRAY_SIZE(ams_temp_events), \ > +} > + > +#define AMS_CHAN_VOLTAGE(_scan_index, _addr, _alarm) { \ > + .type = IIO_VOLTAGE, \ > + .indexed = 1, \ > + .address = (_addr), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_SCALE), \ > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \ > + .event_spec = (_alarm) ? ams_voltage_events : NULL, \ > + .scan_index = _scan_index, \ > + .num_event_specs = (_alarm) ? ARRAY_SIZE(ams_voltage_events) : 0, \ > +}
| |