lkml.org 
[lkml]   [2021]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v7 2/4] iio: adc: Add Xilinx AMS driver
    Date
    Hi Lars,

    Thanks for the review.

    > On 10/19/21 5:20 PM, Anand Ashok Dumbre wrote:
    > > [...]
    > > +#define AMS_CHAN_TEMP(_scan_index, _addr) { \
    > > + .type = IIO_TEMP, \
    > > + .indexed = 1, \
    > > + .address = (_addr), \
    > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
    > > + BIT(IIO_CHAN_INFO_SCALE) | \
    > > + BIT(IIO_CHAN_INFO_OFFSET), \
    > > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \
    > There is no handling of IIO_CHAN_INFO_SAMP_FREQ in read_raw(). Reading
    > the sampling_frequency attribute always returns -EINVAL.
    Correct. I will remove it.

    > > + .event_spec = ams_temp_events, \
    > > + .scan_index = _scan_index, \
    > > + .num_event_specs = ARRAY_SIZE(ams_temp_events), \ }
    > > +
    > > +#define AMS_CHAN_VOLTAGE(_scan_index, _addr, _alarm) { \
    > > + .type = IIO_VOLTAGE, \
    > > + .indexed = 1, \
    > > + .address = (_addr), \
    > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
    > > + BIT(IIO_CHAN_INFO_SCALE), \
    > > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \
    > > + .event_spec = (_alarm) ? ams_voltage_events : NULL, \
    > > + .scan_index = _scan_index, \
    > > + .num_event_specs = (_alarm) ? ARRAY_SIZE(ams_voltage_events) :
    > 0, \
    > > +}

    Also, for some reason, I haven’t received rest of your comments in the mail, but I see them on patchwork.
    I am not sure how I can respond to those comments.

    Thanks,
    Anand
    \
     
     \ /
      Last update: 2021-10-27 11:05    [W:5.786 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site